Skip to content

Comments

Reenable alpha fees#2353

Open
gztensor wants to merge 65 commits intodevnet-readyfrom
feat/re-enable-alpha-fees
Open

Reenable alpha fees#2353
gztensor wants to merge 65 commits intodevnet-readyfrom
feat/re-enable-alpha-fees

Conversation

@gztensor
Copy link
Contributor

Description

Allow paying transaction fees in alpha when no tao balance is available.
See issue #2336 for details.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

The Alpha and TotalHotkeyShares maps will be deprecated in favor of high precision AlphaV2 and TotalHotkeySharesV2.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 16, 2026
@sam0x17
Copy link
Contributor

sam0x17 commented Jan 27, 2026

  • What is the reason we copy zstd-* libs in our repo? I would move zstd-libs into separate crates and reference them like our bls patch.

Yes, I ended up doing this because the upstream zstd crate is broken with respect to no_std when using the particular target we use. I agree we should fork it

@gztensor gztensor marked this pull request as ready for review January 28, 2026 17:20
@gztensor gztensor marked this pull request as draft January 28, 2026 17:21
@gztensor gztensor self-assigned this Jan 28, 2026
@gztensor gztensor marked this pull request as ready for review February 13, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants