feat: add dark mode support to luci-theme-openwrt #8127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CSS variables for theming - Add dark mode toggle button in header - Support automatic system preference detection - Save user preference to localStorage Signed-off-by: Miao,Haifeng <miaohf@sina.com> Signed-off-by: miaohf <miaohf@sina.com>
miaohf
force-pushed
the
miaohaifeng-20251130
branch
from
d4f3bbc to
7610677
Compare
Author
|
comment message updated. |
|
@miaohf: Good job, thanks! |
Contributor
That is actually pretty funny for a guy who has started computing in the era of "only dark mode available", as computer monitors were only CRTs with black background and green or yellow dots on the 80x24 monitor screen. |
systemcrash
reviewed
Dec 4, 2025
| isDark = prefersDark; | ||
| } | ||
|
|
||
| this.updateDarkModeUI(isDark, icon); |
Contributor
There was a problem hiding this comment.
let isDark = savedMode === null ? media.matches : (savedMode === 'true');
const setMode = (dark, save=false) => {
document.documentElement.setAttribute('data-darkmode', dark);
if (save)
localStorage.setItem('luci-darkmode', dark);
this.updateDarkModeUI(dark, icon);
};
setMode(isDark);
systemcrash
reviewed
Dec 4, 2025
|
|
||
| // Get saved preference or detect system preference | ||
| const savedMode = localStorage.getItem('luci-darkmode'); | ||
| const prefersDark = window.matchMedia('(prefers-color-scheme: dark)').matches; |
Contributor
There was a problem hiding this comment.
const media = window.matchMedia('(prefers-color-scheme: dark)');
systemcrash
reviewed
Dec 4, 2025
| if (localStorage.getItem('luci-darkmode') === null) { | ||
| this.updateDarkModeUI(e.matches, icon); | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
toggle.addEventListener('click', () => {
const next = document.documentElement.getAttribute('data-darkmode') !== 'true';
setMode(next, true);
});
// Change when user has not set a preference
media.addEventListener('change', e => {
if (localStorage.getItem('luci-darkmode') === null)
setMode(e.matches);
});
Author
|
:) |
Contributor
|
1 - remove the merge commit - just rebase on master |
Contributor
|
The network interface header names need adjusting because the white text on bright backgrounds are illegible. Same in firewall. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the MakefileDescription
Add dark mode support to luci-theme-openwrt theme.
Features
Implementation
<head>to prevent flash of light modeFiles Changed
cascade.css- Added CSS variables and dark mode style overridesheader.ut- Added dark mode toggle button and early initialization scriptmenu-openwrt.js- Added dark mode toggle logic and localStorage handlingREADME.md- Added documentation for dark mode featureScreenshots
Dark Mode:
Light Mode:
[
]
Toggle Button:
Testing