🌱 Upgrade golanglint from 2.7.2 to 2.8.0 and fix issues by camilamacedo86 · Pull Request #2487 · operator-framework/operator-controller

camilamacedo86 · 2026-02-05T13:28:36Z

Upgrade the lint version and fix the issues:

$ make lint
go build -tags containers_image_openpgp -o ./bin/custom-linter ./hack/ci/custom-linters/cmd
go vet -tags=containers_image_openpgp -vettool=./bin/custom-linter ./...
(re)installing /Users/camilam/go/bin/golangci-lint-v2.8.0
/Users/camilam/go/bin/golangci-lint-v2.8.0 run --build-tags containers_image_openpgp 
internal/catalogd/garbagecollection/garbage_collector_test.go:71:4                                   prealloc  Consider preallocating runtimeObjs with capacity len(tt.existCatalogs)
internal/operator-controller/applier/boxcutter.go:624:6                                              prealloc  Consider preallocating objs
internal/operator-controller/applier/helm.go:384:7                                                   prealloc  Consider preallocating missingRuleDescriptions
internal/operator-controller/authorization/rbac.go:328:6                                             prealloc  Consider preallocating attributeRecords
internal/operator-controller/controllers/clusterextensionrevision_controller_internal_test.go:155:8  prealloc  Consider preallocating names
internal/operator-controller/resolve/catalog.go:240:2                                                prealloc  Consider preallocating matchedCatalogs with capacity len(rei.ResolvedBundles)
internal/operator-controller/rukpak/render/registryv1/validators/validator.go:149:6                  prealloc  Consider preallocating errs
internal/operator-controller/rukpak/render/registryv1/validators/validator.go:182:6                  prealloc  Consider preallocating errs
internal/operator-controller/rukpak/render/registryv1/validators/validator.go:270:6                  prealloc  Consider preallocating errs
9 issues:
* prealloc: 9
make: *** [lint] Error 1

netlify · 2026-02-05T13:28:42Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`146004e`
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6984a1ab4e562600076cd691
😎 Deploy Preview	https://deploy-preview-2487--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR upgrades golangci-lint from version 2.7.2 to 2.8.0 and addresses linter warnings by implementing slice preallocation optimizations throughout the codebase. The changes focus on preallocating slices with appropriate capacities before appending elements in loops to improve memory allocation efficiency.

Changes:

Updated golangci-lint dependency from v2.7.2 to v2.8.0 in build configuration files
Added slice preallocation with capacity hints in 8 Go source files to address prealloc linter warnings
Preallocated slices reduce memory allocations by reserving capacity upfront when the final size can be estimated

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
.bingo/variables.env	Updated golangci-lint version variable to v2.8.0
.bingo/golangci-lint.mod	Updated golangci-lint module requirement to v2.8.0
.bingo/Variables.mk	Updated golangci-lint binary version references and build commands
.bingo/golangci-lint.sum	Updated checksums for golangci-lint v2.8.0 and its dependencies
internal/operator-controller/rukpak/render/render.go	Preallocated error slice with capacity based on number of validators
internal/operator-controller/rukpak/render/registryv1/validators/validator.go	Preallocated error slices in three validator functions with calculated capacities
internal/operator-controller/resolve/catalog.go	Preallocated catalog slice with capacity based on resolved bundles count
internal/operator-controller/controllers/clusterextensionrevision_controller_internal_test.go	Preallocated names slice in test with capacity based on previous revisions count
internal/operator-controller/authorization/rbac.go	Preallocated authorization records slice with estimated capacity calculation
internal/operator-controller/applier/helm.go	Preallocated descriptions slice after counting total missing rules
internal/operator-controller/applier/boxcutter.go	Preallocated objects slice after counting total objects across phases
internal/catalogd/garbagecollection/garbage_collector_test.go	Preallocated runtime objects slice in test with capacity based on existing catalogs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/rukpak/render/registryv1/validators/validator.go

internal/operator-controller/authorization/rbac.go

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-02-05T14:15:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.82%. Comparing base (910fa59) to head (146004e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
+ Coverage   69.73%   73.82%   +4.09%     
==========================================
  Files         102      102              
  Lines        8471     8496      +25     
==========================================
+ Hits         5907     6272     +365     
+ Misses       2091     1743     -348     
- Partials      473      481       +8

Flag	Coverage Δ
e2e	`46.19% <39.39%> (-0.08%)`	⬇️
experimental-e2e	`54.16% <78.78%> (+41.17%)`	⬆️
unit	`57.98% <100.00%> (+0.12%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

perdasilva · 2026-02-06T10:23:24Z

internal/operator-controller/applier/boxcutter.go

 // getObjects returns a slice of all objects in the revision
 func getObjects(rev *ocv1.ClusterExtensionRevision) []client.Object {
-	var objs []client.Object
+	totalObjects := 0


should we just nolint instead? it seems like over optimization somehow...or are there good reasons to do this?

nolint we ignore the error
IHMO we should fix. Why not fix the error?

PS.: All still passing on the tests so I think we can be confident that nothing change here.

We normally fix the issues and not add //nolint.
I think you raised the concern because a comment in OPM.operator-framework/operator-registry#1898 (comment)

But that is because the project is like legacy one and either we must understand better with jordan what he meant with that.

it just feels like extra complexity for the sole purpose of avoiding adding // nolint. Don't get me wrong, I think it should be used sparingly and we definitely should try to fix the issues rather than sidestep them. I'm just trying to understand if the added code is worth it (i.e. are we in a situation in which it makes some sense to use nolint?)

So, besides removing the lint issue, what do we gain by running ahead of every slice allocation to allocated it to the exact right size in these cases?

Yes that is an optimization / performance / memory

perdasilva · 2026-02-06T10:23:47Z

internal/operator-controller/applier/helm.go

 	var preAuthErrors []error
 	if len(missingRules) > 0 {
-		var missingRuleDescriptions []string
+		totalMissingRules := 0


same as before

pedjak · 2026-02-06T13:24:15Z

Are all these changes consequences of upgrading lint version?

camilamacedo86 · 2026-02-06T13:46:45Z

Are all these changes consequences of upgrading lint version?

Yes. They are. The changes here are to face the issue:

$ make lint
go build -tags containers_image_openpgp -o ./bin/custom-linter ./hack/ci/custom-linters/cmd
go vet -tags=containers_image_openpgp -vettool=./bin/custom-linter ./...
(re)installing /Users/camilam/go/bin/golangci-lint-v2.8.0
/Users/camilam/go/bin/golangci-lint-v2.8.0 run --build-tags containers_image_openpgp 
internal/catalogd/garbagecollection/garbage_collector_test.go:71:4                                   prealloc  Consider preallocating runtimeObjs with capacity len(tt.existCatalogs)
internal/operator-controller/applier/boxcutter.go:624:6                                              prealloc  Consider preallocating objs
internal/operator-controller/applier/helm.go:384:7                                                   prealloc  Consider preallocating missingRuleDescriptions
internal/operator-controller/authorization/rbac.go:328:6                                             prealloc  Consider preallocating attributeRecords
internal/operator-controller/controllers/clusterextensionrevision_controller_internal_test.go:155:8  prealloc  Consider preallocating names
internal/operator-controller/resolve/catalog.go:240:2                                                prealloc  Consider preallocating matchedCatalogs with capacity len(rei.ResolvedBundles)
internal/operator-controller/rukpak/render/registryv1/validators/validator.go:149:6                  prealloc  Consider preallocating errs
internal/operator-controller/rukpak/render/registryv1/validators/validator.go:182:6                  prealloc  Consider preallocating errs
internal/operator-controller/rukpak/render/registryv1/validators/validator.go:270:6                  prealloc  Consider preallocating errs
9 issues:
* prealloc: 9
make: *** [lint] Error 1

I am adding it to the description as well.

pedjak

/lgtm

perdasilva · 2026-02-09T09:22:57Z

/approve

openshift-ci · 2026-02-09T09:23:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI review requested due to automatic review settings February 5, 2026 13:28

openshift-ci bot requested review from dtfranz and tmshort February 5, 2026 13:28

Copilot started reviewing on behalf of camilamacedo86 February 5, 2026 13:28 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

internal/operator-controller/rukpak/render/registryv1/validators/validator.go Outdated Show resolved Hide resolved

internal/operator-controller/authorization/rbac.go Outdated Show resolved Hide resolved

camilamacedo86 changed the title ~~🌱 Upgrade golanglint from 2.7.2 to 2.8.0 and fix issues~~ WIP 🌱 Upgrade golanglint from 2.7.2 to 2.8.0 and fix issues Feb 5, 2026

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2026

Upgrade golanglint from 2.7.2 to 2.8.0

146004e

camilamacedo86 force-pushed the lint branch from 18ff02c to 146004e Compare February 5, 2026 13:56

camilamacedo86 requested a review from Copilot February 5, 2026 13:57

Copilot started reviewing on behalf of camilamacedo86 February 5, 2026 13:58 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

camilamacedo86 changed the title ~~WIP 🌱 Upgrade golanglint from 2.7.2 to 2.8.0 and fix issues~~ 🌱 Upgrade golanglint from 2.7.2 to 2.8.0 and fix issues Feb 5, 2026

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2026

perdasilva reviewed Feb 6, 2026

View reviewed changes

pedjak reviewed Feb 6, 2026

View reviewed changes

openshift-ci bot assigned pedjak Feb 6, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2026

openshift-merge-bot bot merged commit 1624bed into operator-framework:main Feb 9, 2026
37 checks passed

Comments

Conversation

camilamacedo86 commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codecov bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

perdasilva Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

perdasilva Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

perdasilva Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

pedjak commented Feb 6, 2026

Uh oh!

camilamacedo86 commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedjak left a comment

Choose a reason for hiding this comment

Uh oh!

perdasilva commented Feb 9, 2026

Uh oh!

openshift-ci bot commented Feb 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camilamacedo86 commented Feb 5, 2026 •

edited

Loading

netlify bot commented Feb 5, 2026 •

edited

Loading

codecov bot commented Feb 5, 2026 •

edited

Loading

camilamacedo86 Feb 6, 2026 •

edited

Loading

perdasilva Feb 6, 2026 •

edited

Loading

camilamacedo86 commented Feb 6, 2026 •

edited

Loading