Skip to content

Comments

🐛 Fix release: disable buildx provenance so docker manifest create succeed#2517

Merged
camilamacedo86 merged 1 commit intooperator-framework:mainfrom
camilamacedo86:fix-release
Feb 19, 2026
Merged

🐛 Fix release: disable buildx provenance so docker manifest create succeed#2517
camilamacedo86 merged 1 commit intooperator-framework:mainfrom
camilamacedo86:fix-release

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Feb 19, 2026

Fix the issue: https://github.com/operator-framework/operator-controller/actions/runs/22177015029/job/64128180855

Docker Buildx enables provenance attestations by default (BuildKit v0.11+). Each per-arch image is then pushed as a manifest list (image + attestation). Goreleaser’s docker manifest create step expects single image manifests when combining -amd64, -arm64, etc. into one tag, so it fails with “X is a manifest list”.

Adding --provenance=false to the docker build flags makes each arch a single manifest so the combined multi-arch manifest can be created successfully.

Copilot AI review requested due to automatic review settings February 19, 2026 10:20
@openshift-ci openshift-ci bot requested review from OchiengEd and dtfranz February 19, 2026 10:20
@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b7ddcea
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6996e3fb24720000086f1504
😎 Deploy Preview https://deploy-preview-2517--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Docker build issue in the release pipeline by disabling buildx provenance attestations, which was causing docker manifest create operations to fail during the release process.

Changes:

  • Added --provenance=false flag to all 8 Docker buildx configurations in .goreleaser.yml (4 architectures × 2 images: operator-controller and catalogd)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.21%. Comparing base (fb28936) to head (b7ddcea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2517      +/-   ##
==========================================
- Coverage   73.23%   73.21%   -0.03%     
==========================================
  Files         102      102              
  Lines        8505     8505              
==========================================
- Hits         6229     6227       -2     
- Misses       1801     1802       +1     
- Partials      475      476       +1     
Flag Coverage Δ
e2e 45.91% <ø> (+0.02%) ⬆️
experimental-e2e 53.50% <ø> (+0.08%) ⬆️
unit 57.87% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 merged commit 553e210 into operator-framework:main Feb 19, 2026
33 of 35 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-release branch February 19, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants