🐛 Fix release: disable buildx provenance so docker manifest create succeed#2517
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR fixes a Docker build issue in the release pipeline by disabling buildx provenance attestations, which was causing docker manifest create operations to fail during the release process.
Changes:
- Added
--provenance=falseflag to all 8 Docker buildx configurations in.goreleaser.yml(4 architectures × 2 images: operator-controller and catalogd)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2517 +/- ##
==========================================
- Coverage 73.23% 73.21% -0.03%
==========================================
Files 102 102
Lines 8505 8505
==========================================
- Hits 6229 6227 -2
- Misses 1801 1802 +1
- Partials 475 476 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
553e210
into
operator-framework:main
Fix the issue: https://github.com/operator-framework/operator-controller/actions/runs/22177015029/job/64128180855
Docker Buildx enables provenance attestations by default (BuildKit v0.11+). Each per-arch image is then pushed as a manifest list (image + attestation). Goreleaser’s docker manifest create step expects single image manifests when combining -amd64, -arm64, etc. into one tag, so it fails with “X is a manifest list”.
Adding
--provenance=falseto the docker build flags makes each arch a single manifest so the combined multi-arch manifest can be created successfully.