Skip to content

Comments

🌱 Rename rev to cer in ClusterExtensionRevision reconciler for consistency#2522

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
perdasilva:small-cer-refactor
Feb 24, 2026
Merged

🌱 Rename rev to cer in ClusterExtensionRevision reconciler for consistency#2522
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
perdasilva:small-cer-refactor

Conversation

@perdasilva
Copy link
Contributor

Description

Standardize the parameter name from rev to cer across reconcile, establishWatch, listPreviousRevisions, and toBoxcutterRevision methods to match the naming convention used elsewhere in the controller. Also simplify the establishWatch signature to a single line.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Standardize the parameter name from `rev` to `cer` across reconcile,
establishWatch, listPreviousRevisions, and toBoxcutterRevision methods
to match the naming convention used elsewhere in the controller. Also
simplify the establishWatch signature to a single line.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 24, 2026 10:57
@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 10c9239
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/699d840d08ee1d0008439cfa
😎 Deploy Preview https://deploy-preview-2522--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the parameter naming in the ClusterExtensionRevision reconciler by renaming rev to cer across multiple methods. This aligns with the naming convention already established in other methods of the same reconciler (e.g., delete, archive, and all status helper functions).

Changes:

  • Renamed parameter from rev to cer in four reconciler methods for consistency
  • Renamed boxcutterRev to revision in establishWatch method
  • Simplified the establishWatch method signature to a single line

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.08%. Comparing base (ddf921f) to head (10c9239).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...controllers/clusterextensionrevision_controller.go 83.33% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
+ Coverage   70.11%   72.08%   +1.96%     
==========================================
  Files         103      103              
  Lines        8686     8686              
==========================================
+ Hits         6090     6261     +171     
+ Misses       2145     1944     -201     
- Partials      451      481      +30     
Flag Coverage Δ
e2e 45.36% <0.00%> (?)
experimental-e2e 53.67% <73.80%> (-0.30%) ⬇️
unit 57.12% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 4121321 into operator-framework:main Feb 24, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants