Skip to content

Comments

MON-4513: Use endpointslices for metrics#3773

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
tmshort:mon-4513
Feb 19, 2026
Merged

MON-4513: Use endpointslices for metrics#3773
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
tmshort:mon-4513

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Feb 18, 2026

  • Add permissions on endpointslice to Prometheus Role
  • Use serviceDiscoveryRole: EndpointSlice in ServiceMonitors

* Add permissions on endpointslice to Prometheus Role
* Use serviceDiscoveryRole: EndpointSlice in ServiceMonitors

Signed-off-by: Todd Short <todd.short@me.com>
Copy link
Contributor

@oceanc80 oceanc80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2026
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oceanc80, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 12f8f48 into operator-framework:master Feb 19, 2026
14 checks passed
@tmshort tmshort deleted the mon-4513 branch February 19, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants