Skip to content

Comments

handle cases where spec.version.release is a number instead of string#1909

Open
grokspawn wants to merge 1 commit intooperator-framework:masterfrom
grokspawn:release-number-fix
Open

handle cases where spec.version.release is a number instead of string#1909
grokspawn wants to merge 1 commit intooperator-framework:masterfrom
grokspawn:release-number-fix

Conversation

@grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Feb 6, 2026

Assisted-By: claude

Description of the change:
explicitly handles the case where a CSV's spec.release version is represented as an int or float instead of a string.

Motivation for the change:
while the tooling in operator-framework should always steer towards CSVs which use string release values, there remain a variety of ways to generate a CSV which might result in a numerical value for release. So we need to provide a more flexible import approach to encompass these capabilities.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: grokspawn <jordan@nimblewidget.com>
Assisted-By: claude
@openshift-ci openshift-ci bot requested review from anik120 and kevinrizza February 6, 2026 05:12
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.48%. Comparing base (a40ca89) to head (10fed99).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1909      +/-   ##
==========================================
+ Coverage   57.44%   57.48%   +0.03%     
==========================================
  Files         139      139              
  Lines       13323    13328       +5     
==========================================
+ Hits         7653     7661       +8     
+ Misses       4488     4485       -3     
  Partials     1182     1182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant