Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## stable #403 +/- ##
==========================================
+ Coverage 73.80% 75.12% +1.32%
==========================================
Files 92 93 +1
Lines 8548 8560 +12
Branches 1680 1678 -2
==========================================
+ Hits 6309 6431 +122
+ Misses 1793 1676 -117
- Partials 446 453 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dgarros
approved these changes
May 10, 2025
Contributor
dgarros
left a comment
There was a problem hiding this comment.
Looks good,
I think we should do the same change for subtract as well just below add
Deploying infrahub-sdk-python with
|
| Latest commit: |
d762fb6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e3c2d131.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://ajtm-05092025-timestamp-add.infrahub-sdk-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instantiate the new timestamp as
self.__class__instead ofTimestampso that we keep the correct classfor example, infrahub has its own
Timestampclass that inherites from the sdk'sTimestampand calling.addon an infrahubTimestampyields an sdkTimestamp