You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to opsmill/infrahub#8311, we want the SDK to raise our own Jinja2 errors when there are syntax errors in user submitted templates. Then Infrahub could look for those errors specifically.
Summary by CodeRabbit
Bug Fixes
Improved error handling for template syntax errors with accurate line number reporting for easier debugging.
Standardized error messages for template-related issues.
Tests
Added comprehensive test coverage for template syntax error scenarios to ensure reliable error reporting.
The changes implement standardized error handling for Jinja2 template syntax errors. In infrahub_sdk/template/__init__.py, env.parse(template_source) calls in the get_variables and validate functions are wrapped in try/except blocks to catch jinja2.TemplateSyntaxError. When caught, these errors are delegated to _raise_template_syntax_error, which raises a JinjaTemplateSyntaxError with adjusted filename and line number information for file-based templates. Corresponding test coverage is added in tests/unit/sdk/test_template.py with a test data structure and two parametrized test functions validating error messages and line numbers across multiple syntax error scenarios.
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The title 'Raise SDK specific Jinja errors on syntax error' directly and accurately summarizes the main change: implementing SDK-specific error types for Jinja syntax errors.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to opsmill/infrahub#8311, we want the SDK to raise our own Jinja2 errors when there are syntax errors in user submitted templates. Then Infrahub could look for those errors specifically.
Summary by CodeRabbit
Bug Fixes
Tests