Skip to content

Conversation

@SamuelDev
Copy link

Related Issue or Design Document

Docs updates for client secret rotation

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@SamuelDev
Copy link
Author

Javascript integration test failure seems like a CI issue and unrelated to these changes

@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Jan 23, 2026
@alnr alnr added the area/docs This issue affects Ory's documentation. label Feb 10, 2026
@alnr
Copy link
Contributor

alnr commented Feb 11, 2026

@wassimoo @unatasha8 would you kindly take a look at this pls?

@vinckr vinckr force-pushed the client-secret-rotation-docs branch from 19afb45 to 29299a0 Compare February 11, 2026 23:14
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :) fixed some layout issues

## Rotate OAuth2 client secret

OAuth2 client secret rotation allows you to change a client's secret without downtime. When you rotate a secret, the old secret
remains valid until you explicitly clean it up, allowing you to update all services using the client credentials without service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
remains valid until you explicitly clean it up, allowing you to update all services using the client credentials without service
remains valid until you remove it, allowing you to update all your services without service


##### How secret rotation works

1. Rotate the secret: Generate a new secret for the client
Copy link
Contributor

@unatasha8 unatasha8 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Rotate the secret: Generate a new secret for the client
1. Generate a new secret for the client service

##### How secret rotation works

1. Rotate the secret: Generate a new secret for the client
2. Both secrets work: Old and new secrets both authenticate until cleanup
Copy link
Contributor

@unatasha8 unatasha8 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be #3 not #2. The new secret won't work until you update the client application, right?
Move position and change to: "Both old and new secrets authenticate until you remove the old secret."


1. Rotate the secret: Generate a new secret for the client
2. Both secrets work: Old and new secrets both authenticate until cleanup
3. Update services: Update your applications to use the new secret
Copy link
Contributor

@unatasha8 unatasha8 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Update services: Update your applications to use the new secret
3. Update your client services to use the new secret

1. Rotate the secret: Generate a new secret for the client
2. Both secrets work: Old and new secrets both authenticate until cleanup
3. Update services: Update your applications to use the new secret
4. Cleanup: Manually remove old rotated secrets once all services are updated
Copy link
Contributor

@unatasha8 unatasha8 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Cleanup: Manually remove old rotated secrets once all services are updated
4. After you test the client services can authenticate with the new secret, manually remove the old secret.


##### Clear rotated secrets

Once all services have been updated to use the new secret, you can remove the old rotated secrets to revoke access using the old
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once all services have been updated to use the new secret, you can remove the old rotated secrets to revoke access using the old
Once all services are updated to use the new secret, remove the old secret to revoke access using the old

##### Clear rotated secrets

Once all services have been updated to use the new secret, you can remove the old rotated secrets to revoke access using the old
credentials:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
credentials:
secret:

-H "Authorization: Bearer ory_pat_..."
```

After cleanup, only the current secret will be valid. Old secrets will no longer authenticate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After cleanup, only the current secret will be valid. Old secrets will no longer authenticate.
After removing the old secret, only the current (new) secret is valid. The old secret can no longer authenticate.

id: clientId
})

// Old secrets are now revoked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Old secrets are now revoked
// Old secret is now revoked.


echo "New secret: $NEW_SECRET"

# 3. Update your applications with the new secret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 3. Update your applications with the new secret
# 3. Update your client servcies with the new secret

-u "$CLIENT_ID:$NEW_SECRET" \
-d "grant_type=client_credentials"

# 5. Once all services are updated, clean up old secrets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 5. Once all services are updated, clean up old secrets
# 5. Once all client services are updated, remove the old secret


:::tip Zero-downtime credential rotation

Secret rotation enables zero-downtime credential updates. Both the old and new secrets remain valid until you manually clean up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Secret rotation enables zero-downtime credential updates. Both the old and new secrets remain valid until you manually clean up
Secret rotation enables zero-downtime credential updates. Both the old and new secrets remain valid until you manually remove

:::tip Zero-downtime credential rotation

Secret rotation enables zero-downtime credential updates. Both the old and new secrets remain valid until you manually clean up
the rotated secrets, allowing you to update all your services without service interruption.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the rotated secrets, allowing you to update all your services without service interruption.
the old secret, allowing you to update all your client services without service interruption.


:::warning Security best practice

Rotated secrets remain valid indefinitely until you explicitly clean them up. Always remove old rotated secrets once your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Rotated secrets remain valid indefinitely until you explicitly clean them up. Always remove old rotated secrets once your
Secrets remain valid indefinitely until you explicitly remove them. Always remove old secrets once your

:::warning Security best practice

Rotated secrets remain valid indefinitely until you explicitly clean them up. Always remove old rotated secrets once your
migration is complete to ensure that compromised credentials cannot be used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
migration is complete to ensure that compromised credentials cannot be used.
secret rotation process is complete to ensure that compromised credentials cannot be used.


:::warning Security best practice

Rotated secrets remain valid indefinitely until you explicitly clean them up. Always remove old rotated secrets once your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"secrets remain valid indefinitely" Are you sure? Don't they have a validity date?

Deepak just added this feature: "The SAML connection includes a valid_to attribute, which is an array of expiry dates for the signing certificates associated". This might not directly link to your code as it's for SAML... but wanted to point it out to you.

3. Update services: Update your applications to use the new secret
4. Cleanup: Manually remove old rotated secrets once all services are updated

##### Rotate client secret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##### Rotate client secret
##### Rotate OAuth2 client secret

-H "Authorization: Bearer ory_pat_..."
```

The response includes the new `client_secret`. Save this value immediately - it will not be shown again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should this be saved? Is there a secure location it should be saved to?

</Tabs>
````

##### Clear rotated secrets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##### Clear rotated secrets
##### Remove old secret

Copy link
Contributor

@unatasha8 unatasha8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, keep to singular for 'secret' if the process is one at a time. Pick one to use client(s), client service(s), service(s), application(s) etc. I tried to change all to client services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs This issue affects Ory's documentation. upstream Issue is caused by an upstream dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants