feat: added note about certificate expiry details #2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakprabhakara
requested review from
aeneasr,
unatasha8 and
vinckr
as code owners
vinckr
changed the title
Co-authored-by: Vincent <vincent@ory.sh>
vinckr
approved these changes
Feb 11, 2026
Member
vinckr
left a comment
vinckr
left a comment
There was a problem hiding this comment.
please run make format to pass the CI :)
also please merge this only after the feature is released, thanks
unatasha8
requested changes
Feb 11, 2026
Contributor
unatasha8
left a comment
unatasha8
left a comment
There was a problem hiding this comment.
Does each SAML connection have more than one signing certificate?
|
|
||
| #### Signing certificate expiry details | ||
|
|
||
| The SAML connection includes a `valid_to` attribute, which is an array of expiry dates for the signing certificates associated |
Contributor
There was a problem hiding this comment.
Does each SAML connection have multiple signing certificates?
Contributor
Author
There was a problem hiding this comment.
Yes it can have multiple signing certificates (generally for rotation) but usually just 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
https://github.com/ory-corp/cloud/pull/10640
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
Further comments