bib: fix anaconda-iso mTLS key extraction #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a (subtle) bug in the ibcli version of the mTLS key exaction. It was happening too late, i.e. when the bootc container was already unmounted. This commit moves the extraction into the `Depsolve` function which is run while the container is mounted which means we can extract the mTLS config. Note that this was not discovered earlier because we lack and end-to-end test for RHEL based bootc images :(
mvo5
requested review from
bcl,
croissanne and
thozza
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a (subtle) bug in the ibcli version of the mTLS key exaction. It was happening too late, i.e. when the bootc container was already unmounted.
This commit moves the extraction into the
Depsolvefunction which is run while the container is mounted which means we can extract the mTLS config.Note that this was not discovered earlier because we lack and end-to-end test for RHEL based bootc images :(
The test is in #403 - I ran it locally and it works but I wanted to get this fix in ASAP as it blocks osbuild/bootc-image-builder#1157