main: embed manifestgen.options into manifestOptions #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we generate the osbuild manifest we need to take a bunch of commandline options into account. These are collected and passed via `manifestOptions` in the CLI. There is a (small) overlap with options that are then "converted" to options that need to be passed to `manifestgen` via `manifestgen.Options`. Previously there was manual code for this but its slightly nicer to just embedd the `manifestgen.Options` into the more general `manifestOptions` of the CLI. This avoid some boilerplate code and might serve as a useful pattern in other places. So this commit does that now (even though the wins are not that big).
mvo5
requested review from
croissanne,
lzap and
supakeen
and removed request for
a team
lzap
approved these changes
Dec 18, 2025
| } | ||
|
|
||
| opts := &manifestOptions{ | ||
| ManifestgenOptions: manifestgen.Options{ |
Contributor
There was a problem hiding this comment.
Frankly, I do not like Options suffix. We have one extreme when everything is SomethingCustomizations. I suggest to consider naming this just Manifestgen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[this is part of https://github.com//pull/415 but given that this one is controversial (as expected) I open this as a separate PR because I think its nice on its own]
When we generate the osbuild manifest we need to take a bunch of commandline options into account. These are collected and passed via
manifestOptionsin the CLI. There is a (small) overlap with options that are then "converted" to options that need to be passed tomanifestgenviamanifestgen.Options.Previously there was manual code for this but its slightly nicer to just embedd the
manifestgen.Optionsinto the more generalmanifestOptionsof the CLI. This avoid some boilerplate code and might serve as a useful pattern in other places. So this commit does that now (even though the wins are not that big).