data: install tmpfiles.d/image-builder.conf to auto-clean cache #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
tmpfiles-d-cache-cleanup
branch
3 times, most recently
from
f57b06a to
8ac69dd
Compare
mvo5
requested review from
bcl,
croissanne and
supakeen
and removed request for
a team
supakeen
requested changes
Dec 17, 2025
Member
There was a problem hiding this comment.
We'd need to build require systemd-rpm-macros, use a source macro for the drop in, and I think we also need to own /var/cache/image-builder if I read https://docs.fedoraproject.org/en-US/packaging-guidelines/Tmpfiles.d/#_example_spec_file correctly?
Our osbuild/image-builder cache is located in /var/cache/image-builder and it can grow quite big. To avoid it growing out of bounds too much add a tmpfile.d snippet to ensure that we clean content older than 14d. The 14d is a bit arbitrary, happy to change to longer or shorter cache timeouts (side-note: we have a cache limit in osbuild and an LRU there too but sources are currently not part of the cache limits in osbuild).
mvo5
force-pushed
the
tmpfiles-d-cache-cleanup
branch
from
8ac69dd to
3954d50
Compare
Contributor
Author
Thank you! My rpm-foo is weak :) I updated the spec file, hope I got it right with the %ghost dir as both ibcli and tmpfiles.d will create the dir as needed but if I should create it in the rpm that is fine, happy to do that too. |
supakeen
approved these changes
Dec 17, 2025
Member
supakeen
left a comment
supakeen
left a comment
There was a problem hiding this comment.
I think this is fine now! Thank you.
lzap
approved these changes
Dec 18, 2025
Contributor
|
One RPM build failed, but I am unable to download logs I see a timeout error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our osbuild/image-builder cache is located in /var/cache/image-builder and it can grow quite big. To avoid it growing out of bounds too much add a tmpfile.d snippet to ensure that we clean content older than 14d. The 14d is a bit arbitrary, happy to change to longer or shorter cache timeouts (side-note: we have a cache limit in osbuild and an LRU there too but sources are currently not part of the cache limits in osbuild).