Fix inner/outer ring accessor boost::geometry adaptor types/functions#2319
Merged
lonvia merged 1 commit intoosm2pgsql-dev:masterfrom Apr 22, 2025
Merged
Fix inner/outer ring accessor boost::geometry adaptor types/functions#2319lonvia merged 1 commit intoosm2pgsql-dev:masterfrom
lonvia merged 1 commit intoosm2pgsql-dev:masterfrom
Conversation
These types/functions are used to let boost functions access our polygon/ring types. They are supposed to return (const) references. I found the bug while doing more complicated geometry processing, working on some future code for osm2pgsql. It seems the buggy code does not produce any problems in current code, but I can not guarantee it. Theoretically it could lead to crashes. It might make some code slower, though, because of unnecessary copying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These types/functions are used to let boost functions access our polygon/ring types. They are supposed to return (const) references.
I found the bug while doing more complicated geometry processing, working on some future code for osm2pgsql. It seems the buggy code does not produce any problems in current code, but I can not guarantee it. Theoretically it could lead to crashes. It might make some code slower, though, because of unnecessary copying.