Scheme

[877509395]

just to show error, not PR.

[martinhsv]

Hi @877509395 ,

Thanks for highlighting that.

The logic is indeed not correct for what was intended, and should get fixed.

Note, however, that it doesn't look like there is any circumstance with the currently-supported v3 deployment (with nginx and the ModSecurity-nginx connector), that this code path will execute.

If you think I'm mistaken and the effect is relatively trivial, feel free to post here. If you think I'm mistaken and the effect is more consequential (possible rule bypass, etc.) please outline the use case to us at the address listed at https://github.com/SpiderLabs/ModSecurity#security-issue .

(Note: For future reference, items like this are better created as 'issues' rather than pull requests.)

[877509395]

OK, will open issue later. Will double check the code later.

…

------------------ 原始邮件 ------------------ 发件人: "SpiderLabs/ModSecurity" ***@***.***>; 发送时间: 2022年4月22日(星期五) 晚上11:18 ***@***.***>; ***@***.******@***.***>; 主题: Re: [SpiderLabs/ModSecurity] Scheme (PR #2721) Hi @877509395 , Thanks for highlighting that. The logic is indeed not correct for what was intended, and should get fixed. Note, however, that it doesn't look like there is any circumstance with the currently-supported v3 deployment (with nginx and the ModSecurity-nginx connector), that this code path will execute. If you think I'm mistaken and the effect is relatively trivial, feel free to post here. If you think I'm mistaken and the effect is more consequential (possible rule bypass, etc.) please outline the use case to us at the address listed at https://github.com/SpiderLabs/ModSecurity#security-issue . (Note: For future reference, items like this are better created as 'issues' rather than pull requests.) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>