refactor: remove NGINX support from v2 (#3498)

[sanjib2006]

what

Followed #3498 and removed the NGINX module and related things

files and folders deleted/modified other than mentioned directly in the issue:

• standalone/server.c: Changed ap_server_argv0 value from "nginx" to "standalone".
• tests/regression/action/00-disruptive-actions.t: Removed NGINX-specific test expectations (nginx => ...).
• tests/regression/config/00-load-modsec.t: Removed NGINX-specific test expectations.
• tests/regression/nginx/: Deleted directory containing NGINX-specific regression test configurations

why

• The NGINX module for v2 is not feature-complete, and I removed the related files as mentioned in the issue

references

• RFC: Let's kill mod_security2 for NGINX #3498

[fzipi]

For now it looks good. I'll grep to see if we need to cleanup additional stuff.

[fzipi]

Maybe adding on top of CHANGES:

DD MMM YYYY - 2.9.13
--------------------

 * chore: removed support for nginx in v2.x

So it is documented there also.

[sanjib2006]

These were commented out so I did not touch them in this commit

• Lines: 613-644, tests/regression/config/10-request-directives.t
• Lines: 110-145, tests/regression/config/10-audit-directives.t

[airween]

So it is documented there also.

Just fyi: I don't expect any maintainers to fill up the CHANGELOG. Usually I can collect all changes from PR's. But as you want...

[sanjib2006]

So should I edit the CHANGELOG??

[airween]

So should I edit the CHANGELOG??

You don't need to edit, but you can (through a regular commit) 😃.

As I wrote, I always collect all PR's and fill the changelog before releases.

[sanjib2006]

ok I won't edit that 😄

[airween]

@sanjib2006 thanks for this PR.

I've made a review, please take a look at my comments.

And here are some more staff that you might review too:

• please run command grep -riI nginx doc/* in your source root, and remove nginx patterns from all occurrences
• there are two tests (you mentioned them previously), in tests/regression/config/10-request-directives.t and tests/regression/config/10-audit-directives.t; just remove them, those are not relevant anymore

Thanks again!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[airween]

LGTM!

[airween]

Thank you @sanjib2006!