Conversation
|
Curvenote Preview
|
tarleb
approved these changes
Feb 4, 2026
tarleb
left a comment
tarleb
left a comment
There was a problem hiding this comment.
Thumbs up from here 👍
I'd like to throw out there the idea of renaming Code to CodeListing, just because that seems like a nice name and would keep naming closer to HTML. But I also like the "blocks first" naming convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This opens up the initial nodes. I have opted not to talk about a document/root type yet (maybe a mistake?). I am hoping these are not controversial. The naming convention needs some review, I went back and forth and don't quite remember the conversations in November or where we landed.