feat!: streamline DBC code generation and file writing #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
tegimeki
approved these changes
Jan 23, 2026
Member
tegimeki
left a comment
tegimeki
left a comment
There was a problem hiding this comment.
This looks like a cleaner API 👍
Make code generator easier to use with simpler functions: * `Config::write_to_file(path)` * `Config::write(impl Write)` * `Config::generate() -> String` The original `codegen` is now private. This is a breaking change, but considering a large number of planned modifications to the generated code, this seems like a minor thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make code generator easier to use with simpler functions:
Config::write_to_file(path)Config::write(impl Write)Config::generate() -> StringThe original
codegenis now private. This is a breaking change, but considering a large number of planned modifications to the generated code, this seems like a minor thing.