Add a note to make sure bootable OS installer ISO is used #28
Conversation
sudomateo
left a comment
sudomateo
left a comment
There was a problem hiding this comment.
Thanks for working on this! I left some non-blocking comments and suggestions to, hopefully, make the wording more concise without losing the meaning. Let me know what you think!
README.adoc
Outdated
| To validate your Windows ISO, check the `VolumeId` using `7z`: | ||
|
|
||
| ```bash | ||
| 7z l your-windows.iso | grep "VolumeId:" |
There was a problem hiding this comment.
Does the grep return anything in the happy path that the user should look out for? You mention the things that occur in the error path but perhaps it's worth showing the user the happy path as well.
There was a problem hiding this comment.
We could consider something like the following too, although I'm not always partial to multiple invocations in the same code block.
# Correct!
$ 7z l your-windows.iso | grep "VolumeId:"
VolumeId: Happy Path
# Incorrect.
$ 7z l your-windows.iso | grep "VolumeId:"
VolumeId: FOD
# Incorrect.
$ 7z l your-windows.iso | grep "VolumeId:"
VolumeId: LPThere was a problem hiding this comment.
Thank you so much for the review and suggestions. I tried to address the happy/error path examples in the new commit (a589bc1). Looking forward to hearing how it looks
There was a problem hiding this comment.
Those changes look good! I pushed e604cdf based on @qdzlug's feedback. I don't have the Wi-Fi bandwidth to download the Windows ISOs and test this setup myself. Could you run the updated commands and let me know if they work correctly? If not, we can revert to the LogicalVolumeId method. I used an AI agent to discuss this a bit in https://ampcode.com/threads/T-019bdd33-c2b3-73e5-a383-a78a94dcde5f.
There was a problem hiding this comment.
Thank you for this @sudomateo
Tested the commands on full installer and FOD iso, and they worked:
# Full installer iso - files exist
$ 7z l windows.iso | grep -E 'sources/(boot|install)\.(wim|esd)'
2022-03-03 04:39:06 ..... 414658108 414658560 sources/boot.wim
2022-03-03 04:39:48 ..... 4340202461 4340203520 sources/install.wim
# FOD iso - files don't exist
$ 7z l win-fod.iso | grep -E 'sources/(boot|install)\.(wim|esd)'
Co-authored-by: Matthew Sanabria <matthew@sanabria.email>
sudomateo
left a comment
sudomateo
left a comment
There was a problem hiding this comment.
Looking great! Just some nitpick suggestions and a question.
README.adoc
Outdated
| LogicalVolumeId: SERVER_FOD_LP_X64FRE_MULTI_DV9 | ||
| ``` | ||
|
|
||
| A valid ISO usually contains `FRE` as the primary descriptor, and should not contain strings that indicate supplemental content, such as `FOD` or `LP`. If you see `FOD` or `LP` in the `VolumeId`, it means you downloaded the wrong ISO. This is not bootable and image build script will fail. |
There was a problem hiding this comment.
Why usually? Would an invalid image contain FRE?
There was a problem hiding this comment.
I looked at the code snippet again and both the good and bad image have FRE in it. Do we need to further clarify or perhaps just be explicit that the negative cases to watch out for are those with FOD or LP.
There was a problem hiding this comment.
I tried to word it but I think I couldn't be clear. A valid (full installer) iso has FRE in it, but without FOD or LP. Language pack iso also has FRE but has additional descriptor (LP or FOD) in its volume id. So we do want only FRE - we don't want additional FOD or LP.
There was a problem hiding this comment.
With #28 (comment) this discussion may be moot. Waiting on confirmation there.
|
Jumping in via email here - couldn’t we just check to see if the image is bootable? That should probably be enough. On Jan 19, 2026, at 17:34, Matthew Sanabria ***@***.***> wrote:
@sudomateo commented on this pull request.
In README.adoc:
+
+To validate your Windows ISO, check the `VolumeId` using `7z`:
+
+```bash
+# Correct!
+$ 7z l windows.iso | grep VolumeId
+ VolumeId: UDF Volume
+ LogicalVolumeId: SSS_X64FREE_EN-US_DV9
+
+# Incorrect.
+$ 7z l win-server-2022.iso | grep VolumeId
+ VolumeId: UDF Volume
+ LogicalVolumeId: SERVER_FOD_LP_X64FRE_MULTI_DV9
+```
+
+A valid ISO usually contains `FRE` as the primary descriptor, and should not contain strings that indicate supplemental content, such as `FOD` or `LP`. If you see `FOD` or `LP` in the `VolumeId`, it means you downloaded the wrong ISO. This is not bootable and image build script will fail.
I looked at the code snippet again and both the good and bad image have FRE in it. Do we need to further clarify or perhaps just be explicit that the negative cases to watch out for are those with FOD or LP.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Co-authored-by: Matthew Sanabria <matthew@sanabria.email>
Relates to SSE-185.
Relates to https://github.com/oxidecomputer/solutions-software-engineering/issues/46.