-
Notifications
You must be signed in to change notification settings - Fork 9
chore: track frac search wait time in explain #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 71.60% 71.40% -0.21%
==========================================
Files 204 204
Lines 14737 14763 +26
==========================================
- Hits 10553 10541 -12
- Misses 3431 3470 +39
+ Partials 753 752 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eguguchkin
approved these changes
Jan 16, 2026
dkharms
approved these changes
Jan 22, 2026
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some search requests, trace file looks like that:

i.e. there are holes when we wait for wait group in Searcher. I decided to expand explain entry as follows:
i.e. number
waiting goroutinesshows how much time we spent waiting and we could do (and probable did) other work. However, if we processing a single search request at a time, then this time is essentially wasted. Obviously, this metric is not absolutely honest, system might have been significantly overloaded.Numbers track times across all cores and do look odd, but I didn't find any other better way. I suppose we could do that, because explain entries are not loaded to tracing storage and we do not visualize them anywhere.