-
Notifications
You must be signed in to change notification settings - Fork 9
perf: store decoded rids #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@seqbenchbot up 0-seqbench search-keyword-exact-match |
|
@seqbenchbot down 0ac06048 |
|
Nice, @dkharms Your request was successfully served. Have a great time! |
ead2529 to
06b4e62
Compare
|
@seqbenchbot up main search-keyword-exact-match |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 71.58% 71.62% +0.04%
==========================================
Files 204 204
Lines 14737 14735 -2
==========================================
+ Hits 10549 10554 +5
+ Misses 3434 3429 -5
+ Partials 754 752 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@seqbenchbot down 6923290d |
2f4ada5 to
837a480
Compare
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
0aaf934 to
6aad8f8
Compare
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|


Description
We store in the cache decompressed (but not decoded) RIDs as
[]byteand on each access to RID block we decode it usingbinary.LittleEndian.Uint64function. This PR changes behaviour to store already decoded RIDs in the cache.There is no memory usage penalty since we just move integers from one representation (
[]byte) to another ([]uint64) without introducing new structures etc.If you have used LLM/AI assistance please provide model name and full prompt: