Skip to content

Conversation

@MarcoGorelli
Copy link
Member

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added (Please use assert_type() to assert the type of any return value)
  • If I used AI to develop this pull request, I prompted it to follow AGENTS.md.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review December 3, 2025 17:59
@MarcoGorelli
Copy link
Member Author

ci failure may be due to new ty release 🤔

@loicdiridollou
Copy link
Member

Thanks for the PR @MarcoGorelli, indeed it’s coming from Ty, I reviewed and looks like it’d just be adding to ty ignores. Can you let us know if those two ignores would alleviate the errors?

Copy link
Member

@loicdiridollou loicdiridollou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Ty ignores are sufficient this should be good to go, thanks @MarcoGorelli! Will merge once CI is good

@cmp0xff
Copy link
Contributor

cmp0xff commented Dec 4, 2025

ty is fixed in #1525.

@loicdiridollou loicdiridollou merged commit 6b7bfc9 into pandas-dev:main Dec 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants