Skip to content

Conversation

@Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Dec 8, 2025

CI was failing due to a merge, which I thought was due to an optype update, but it turns out the culprit is a candidate release of numpy 2.4.0rc1) so this PR keeps that release candidate out of our CI.

Once 2.4.0 is released, there are some issues we will need to fix, because np.double moves from being a type alias of np.floating[_NBitDouble] to being a type alias of np.float64, and that is causing some odd behavior.

@Dr-Irv Dr-Irv marked this pull request as ready for review December 8, 2025 16:58
@Dr-Irv Dr-Irv requested a review from cmp0xff December 8, 2025 16:58
@Dr-Irv Dr-Irv changed the title update np.double and get_slice_bounds pin numpy to <= 2.3.5 Dec 8, 2025
Copy link
Member

@loicdiridollou loicdiridollou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dr-Irv !

@loicdiridollou loicdiridollou merged commit 4d2593a into pandas-dev:main Dec 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants