Skip to content

TST: Fix assertion for TestSetitemNAPeriodDtype::expected #63069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mroeschke wants to merge 5 commits into from
Closed

TST: Fix assertion for TestSetitemNAPeriodDtype::expected #63069

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54e7041
TST: Fix assertion for TestSetitemNAPeriodDtype::expected
mroeschke Nov 11, 2025
ae2376a
Remove redundant condition
mroeschke Nov 26, 2025
bad694e
Merge remote-tracking branch 'upstream/main' into test/fix
mroeschke Nov 26, 2025
e1fa8f1
Merge remote-tracking branch 'upstream/main' into test/fix
mroeschke Dec 1, 2025
f3d98e9
Revert "Remove redundant condition"
mroeschke Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/tests/series/indexing/test_setitem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,7 @@ class TestSetitemNAPeriodDtype(SetitemCastingEquivalents):
def expected(self, key):
exp = Series(period_range("2000-01-01", periods=10, freq="D"))
exp._values.view("i8")[key] = NaT._value
assert exp[key] is NaT or all(x is NaT for x in exp[key])
assert exp[key] is NaT or any(x is NaT for x in exp)
Copy link
Member

@jbrockmendel jbrockmendel Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this was passing before, does it suggest that exp[key] is NaT is always the case?

Copy link
Member Author

@mroeschke mroeschke Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Yeah I think then we can remove the or condition here

Copy link
Member Author

@mroeschke mroeschke Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after removing the condition in ae2376a some jobs are failing to appears we do hit the second condition somtimes

Copy link
Member

@jbrockmendel jbrockmendel Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess depending on key, exp[key] could be a scalar or non-scalar. In the non-scalar case, i would expect the existing all assertion to hold. why am i wrong?

Copy link
Member Author

@mroeschke mroeschke Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK I see now. I missed that key can be a slice.

return exp

@pytest.fixture
Expand Down
Loading