-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Optimize canvas menu organization #3145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optimize canvas menu organization #3145
Conversation
|
🚀 Thanks for opening this pull request! |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughReplaces anchor-based toolbar actions with BrowserMenu and MenuItem components in the Canvas toolbar. The "New", "Load", and "Save" actions, along with element operations ("Add", "Edit", "Duplicate", "Delete"), are now rendered as menu items within two BrowserMenu instances with keyboard shortcut hints integrated. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/dashboard/Data/CustomDashboard/CustomDashboard.react.js`:
- Around line 1281-1327: Add disableMouseDown={true} to each MenuItem under the
"Canvas" and "Element" BrowserMenu instances to prevent double-triggering and
ensure the menu closes: update the MenuItem nodes that call handleNewCanvas,
setState({ showLoadDialog: true }), setState({ showSaveDialog: true }),
setState({ showAddDialog: true }), handleDuplicateElement(selectedElement),
handleEditElement, and handleDeleteElement(selectedElement) to include
disableMouseDown={true}.
# [8.3.0-alpha.26](8.3.0-alpha.25...8.3.0-alpha.26) (2026-01-23) ### Features * Optimize canvas menu organization ([#3145](#3145)) ([1558826](1558826))
|
🎉 This change has been released in version 8.3.0-alpha.26 |
Pull Request
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.