Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Jan 23, 2026

Pull Request

Summary by CodeRabbit

  • New Features

    • Dashboard sidebar now shows all canvases, grouped and alphabetically sorted for easier navigation.
  • Bug Fixes

    • Filter lists now toggle open/closed when clicked instead of always expanding.
  • Removed Features

    • Load Canvas dialog removed.
    • Canvas favoriting and the favorite option in the save dialog removed.

✏️ Tip: You can customize this high-level summary in your review settings.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 23, 2026

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jan 23, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

This PR removes canvas "favorite" and load-dialog functionality, replaces the favorites-based sidebar with grouped, alphabetically sorted canvases, simplifies the SaveCanvasDialog API, and changes CategoryList click handling to toggle filter list visibility.

Changes

Cohort / File(s) Summary
CategoryList toggle behavior
src/components/CategoryList/CategoryList.react.js
Click handler for classes with filters now toggles the class open state (removes if already open, adds if closed); comment updated.
Dashboard refactor & sidebar
src/dashboard/Data/CustomDashboard/CustomDashboard.react.js
Removed LoadCanvasDialog import/state and currentCanvasFavorite state; added expandedSidebarGroups; changed handleSaveCanvas(name, group, favorite)handleSaveCanvas(name, group); replaced favorites-filtered sidebar with alphabetically sorted, grouped canvases; updated CategoryList props (currentCategory, params, filterClicked) and navigation logic.
Save dialog simplification
src/dashboard/Data/CustomDashboard/SaveCanvasDialog.react.js
Removed currentFavorite prop/state and Toggle UI; onSave callback now called with (name, group) instead of (name, group, favorite); import of Toggle removed.

Sequence Diagram(s)

sequenceDiagram
  participant User as User
  participant Cat as CategoryList
  participant Dash as CustomDashboard
  participant Router as Router/URL

  User->>Cat: click class/filter
  Cat->>Cat: toggle openClasses for class id
  Cat-->>Dash: filterClicked(classId, filterId)
  Dash->>Router: navigate to canvas URL / load canvas
  Router-->>Dash: route params
  Dash-->>User: render selected/grouped canvas in sidebar
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete, missing critical sections like Issue link, Approach, and Tasks checklist required by the template. Add the Issue link (Closes: #), describe the Approach/changes, and include the Tasks checklist with appropriate selections.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: removing loading/favorite functionality and adding a canvas tree to the sidebar.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/dashboard/Data/CustomDashboard/CustomDashboard.react.js`:
- Around line 1064-1137: The group headers are generating navigable URLs like
canvas/group_<name> — change the CategoryList linkPrefix to target the current
canvas so group headers keep the existing canvas URL while toggling filters: use
linkPrefix={`canvas/${currentCanvasId}${currentCanvasId ? '?' : ''}`} (reference
currentCanvasId, CategoryList props linkPrefix and params, and
filterClicked/navigateToCanvas) so group items still have ids like
`group_<name>` for highlighting but their links resolve to the real canvas URL
with params for filters.

@mtrezza mtrezza changed the title feat: Remove loading and favorite functionality from canvas feat: Add canvas tree to sidebar instead of loading dialog and favorite functionality Jan 23, 2026
@mtrezza mtrezza merged commit e58dc82 into parse-community:alpha Jan 23, 2026
11 of 12 checks passed
@mtrezza mtrezza deleted the feat/canv-fav branch January 23, 2026 18:55
parseplatformorg pushed a commit that referenced this pull request Jan 23, 2026
# [8.3.0-alpha.27](8.3.0-alpha.26...8.3.0-alpha.27) (2026-01-23)

### Features

* Add canvas tree to sidebar instead of loading dialog and favorite functionality ([#3146](#3146)) ([e58dc82](e58dc82))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.3.0-alpha.27

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants