-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Add canvas tree to sidebar instead of loading dialog and favorite functionality #3146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Thanks for opening this pull request! |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughThis PR removes canvas "favorite" and load-dialog functionality, replaces the favorites-based sidebar with grouped, alphabetically sorted canvases, simplifies the SaveCanvasDialog API, and changes CategoryList click handling to toggle filter list visibility. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant Cat as CategoryList
participant Dash as CustomDashboard
participant Router as Router/URL
User->>Cat: click class/filter
Cat->>Cat: toggle openClasses for class id
Cat-->>Dash: filterClicked(classId, filterId)
Dash->>Router: navigate to canvas URL / load canvas
Router-->>Dash: route params
Dash-->>User: render selected/grouped canvas in sidebar
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/dashboard/Data/CustomDashboard/CustomDashboard.react.js`:
- Around line 1064-1137: The group headers are generating navigable URLs like
canvas/group_<name> — change the CategoryList linkPrefix to target the current
canvas so group headers keep the existing canvas URL while toggling filters: use
linkPrefix={`canvas/${currentCanvasId}${currentCanvasId ? '?' : ''}`} (reference
currentCanvasId, CategoryList props linkPrefix and params, and
filterClicked/navigateToCanvas) so group items still have ids like
`group_<name>` for highlighting but their links resolve to the real canvas URL
with params for filters.
# [8.3.0-alpha.27](8.3.0-alpha.26...8.3.0-alpha.27) (2026-01-23) ### Features * Add canvas tree to sidebar instead of loading dialog and favorite functionality ([#3146](#3146)) ([e58dc82](e58dc82))
|
🎉 This change has been released in version 8.3.0-alpha.27 |
Pull Request
Summary by CodeRabbit
New Features
Bug Fixes
Removed Features
✏️ Tip: You can customize this high-level summary in your review settings.