-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Optimize appearance of graph tick labels on x-axis for date values #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Thanks for opening this pull request! |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThis pull request enhances x-axis date formatting for charts. A new helper function formats timestamps contextually (showing time for ≤24-hour spans, dates otherwise) using browser locale. GraphDataUtils computes dateAxisInfo metadata for date axes, and GraphPanel uses this to configure locale-aware tick labels. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/components/GraphPanel/GraphPanel.react.js`:
- Around line 369-377: The tick callback currently uses the rendered-tick
position (`index`) to look up timestamps, which breaks when Chart.js auto-skips
ticks; update xAxisTicks.callback in GraphPanel.react.js to use the `value`
parameter as the index into dateAxisInfo.rawXValues (i.e., const timestamp =
dateAxisInfo.rawXValues[value]) and keep the fallback to
this.getLabelForValue(value) when timestamp is undefined; ensure this change is
applied inside the dateAxisInfo?.isDateAxis branch that calls
formatDateTickLabel.
# [8.3.0-alpha.28](8.3.0-alpha.27...8.3.0-alpha.28) (2026-01-23) ### Features * Optimize appearance of graph tick labels on x-axis for date values ([#3147](#3147)) ([a9edcaf](a9edcaf))
|
🎉 This change has been released in version 8.3.0-alpha.28 |
Pull Request
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.