-
-
Notifications
You must be signed in to change notification settings - Fork 158
chore: disable default features in Cargo.toml #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable default features in Cargo.toml #1501
Conversation
WalkthroughCargo.toml dependency specs updated: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: coverage
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
🔇 Additional comments (1)
Cargo.toml (1)
36-36: No action needed. The disabling of default features is correct and safe.Line 36
default-features = falsefor actix-web-prometheus has no functional impact—the crate has no default features. Line 107'sdefault-features = false, features = ["process"]for prometheus correctly removes only the "protobuf" default feature (addressing the security alert) while preserving the "process" feature needed forProcessCollectorusage on Linux. The codebase uses only stable prometheus APIs (counters, gauges, histograms) and does not directly depend on protobuf types, so metrics functionality is unaffected.Likely an incorrect or invalid review comment.
disable default features for prometheus and actix-web-prometheus in Cargo.toml
this is to remove the indirect dependency of protobuf crate
to address the dependabot alert raised in enterprise -
https://github.com/parseablehq/enterprise/security/dependabot/2
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.