Skip to content

Fix empty string settings causing validation errors in .pvm files #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanofthe merged 1 commit into from
Feb 17, 2026
Merged

Fix empty string settings causing validation errors in .pvm files #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/lib/schema/fileOps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ export function createGraphFile(name?: string): GraphFile {
// Clean params from all nodes (remove internal UI params, empty values, dead params)
const cleanedNodes = nodes.map(n => cleanNodeForExport(n));

// Clean empty strings to null in settings so they round-trip correctly
// (empty strings are used internally for placeholder display but shouldn't be persisted)
const cleanedSettings = Object.fromEntries(
Object.entries(settings).map(([k, v]) => [k, v === '' ? null : v])
) as SimulationSettings;

return {
version: GRAPH_FILE_VERSION,
metadata: {
Expand All @@ -96,7 +102,7 @@ export function createGraphFile(name?: string): GraphFile {
codeContext: {
code
},
simulationSettings: settings
simulationSettings: cleanedSettings
};
}

Expand Down