Skip to content

Comments

Add OAUTHBEARER support#177

Closed
lpsinger wants to merge 1 commit intopathwaycom:mainfrom
lpsinger:oauthbearer
Closed

Add OAUTHBEARER support#177
lpsinger wants to merge 1 commit intopathwaycom:mainfrom
lpsinger:oauthbearer

Conversation

@lpsinger
Copy link

@lpsinger lpsinger commented Jan 25, 2026

Introduction

To contribute code to the Pathway project, start by discussing your proposed changes on Discord or by filing an issue.
Once approved, follow the fork + pull request model against the main branch, ensuring you've signed the contributor license agreement.

Context

OAUTHBEARER authentication is a feature of rdkafka that is required by NASA's General Coordinates Network. OAUTHBEARER support required rdkafka to be linked with libcurl and also require updating the version of librdkafka.

Fixes #180.

How has this been tested?

Tested on my own macOS computer.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issue(s):

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

OAUTHBEARER authentication is a feature of rdkafka that is required
by [NASA's General Coordinates Network](https://gcn.nasa.gov).
OAUTHBEARER support required rdkafka to be linked with libcurl and
also require updating the version of librdkafka.

Fixes pathwaycom#180.
@lpsinger lpsinger changed the title Attempt to add OAUTHBEARER support Add OAUTHBEARER support Jan 26, 2026
@zxqfd555 zxqfd555 self-assigned this Jan 27, 2026
Copy link
Collaborator

@zxqfd555 zxqfd555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lpsinger,

Thanks a lot for your interest in Pathway! Could you please sign the CLA? It's needed for us to accept any external contributions.

We've put in place a CI pipeline. If you merge the latest commits into your branch, it will run in your pull-request, helping us to test the change.

Could you please also add a line into the changelog ("Unreleased" section, "Added" subsection), describing the nature of the change. It will be useful for the other users, who'll install the framework.

rand = "0.9.1"
rayon = "1.10.0"
rdkafka = { version = "0.37.0", features = ["ssl-vendored", "cmake-build", "zstd"] }
rdkafka = { version = "0.39.0", features = ["ssl-vendored", "cmake-build", "zstd", "curl"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to adjust the libclang.so version to build the 0.39.0. I'd propose to use 0.37.0 to have something we can merge right now, and then we can bump it as the next step.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever reason, my sample code in #180 only works with rdkafka >= 0.38.0. Would rdkafka 0.38.0 be better?

@lpsinger
Copy link
Author

Thanks a lot for your interest in Pathway! Could you please sign the CLA? It's needed for us to accept any external contributions.

Unfortunately my employer is going to be very slow to give me approval to sign the CLA because the person who normally approved such things has retired. If you can make the change yourself that would be better.

@zxqfd555
Copy link
Collaborator

Noted, thank you for the heads-up.
We'll make this change on our side shortly.

@zxqfd555
Copy link
Collaborator

zxqfd555 commented Feb 4, 2026

Hello! I am closing this PR, as the change has been made in a separate PR. The change is already available in the nightly build.

@zxqfd555 zxqfd555 closed this Feb 4, 2026
@lpsinger
Copy link
Author

lpsinger commented Feb 4, 2026

Hello! I am closing this PR, as the change has been made in a separate PR. The change is already available in the nightly build.

Hooray! Thank you!

@lpsinger lpsinger deleted the oauthbearer branch February 5, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable OAUTHBEARER authentication support in rdkafka

3 participants