Conversation
|
|
OAUTHBEARER authentication is a feature of rdkafka that is required by [NASA's General Coordinates Network](https://gcn.nasa.gov). OAUTHBEARER support required rdkafka to be linked with libcurl and also require updating the version of librdkafka. Fixes pathwaycom#180.
zxqfd555
left a comment
There was a problem hiding this comment.
Hey @lpsinger,
Thanks a lot for your interest in Pathway! Could you please sign the CLA? It's needed for us to accept any external contributions.
We've put in place a CI pipeline. If you merge the latest commits into your branch, it will run in your pull-request, helping us to test the change.
Could you please also add a line into the changelog ("Unreleased" section, "Added" subsection), describing the nature of the change. It will be useful for the other users, who'll install the framework.
| rand = "0.9.1" | ||
| rayon = "1.10.0" | ||
| rdkafka = { version = "0.37.0", features = ["ssl-vendored", "cmake-build", "zstd"] } | ||
| rdkafka = { version = "0.39.0", features = ["ssl-vendored", "cmake-build", "zstd", "curl"] } |
There was a problem hiding this comment.
We'll need to adjust the libclang.so version to build the 0.39.0. I'd propose to use 0.37.0 to have something we can merge right now, and then we can bump it as the next step.
There was a problem hiding this comment.
For whatever reason, my sample code in #180 only works with rdkafka >= 0.38.0. Would rdkafka 0.38.0 be better?
Unfortunately my employer is going to be very slow to give me approval to sign the CLA because the person who normally approved such things has retired. If you can make the change yourself that would be better. |
|
Noted, thank you for the heads-up. |
|
Hello! I am closing this PR, as the change has been made in a separate PR. The change is already available in the nightly build. |
Hooray! Thank you! |
Introduction
To contribute code to the Pathway project, start by discussing your proposed changes on Discord or by filing an issue.
Once approved, follow the fork + pull request model against the main branch, ensuring you've signed the contributor license agreement.
Context
OAUTHBEARER authentication is a feature of rdkafka that is required by NASA's General Coordinates Network. OAUTHBEARER support required rdkafka to be linked with libcurl and also require updating the version of librdkafka.
Fixes #180.
How has this been tested?
Tested on my own macOS computer.
Types of changes
Related issue(s):
Checklist: