refactor(logging): aligned error messages with reporting criticality (#1317)

* refactor(logging): aligned error messages with reporting criticality

If we call it an error in the message, we should even also mark it as an error instead of an info or a warning

* refactor(logging): parameters are actually allowed to fail

so we'll use a warning here

* chore(logging): optimized the wording

Author: mfranzke

packages/core/src/lib/buildFooter.js

@@ -29,8 +29,8 @@ module.exports = function (patternlab, patternPartial, uikit) {
           'config.paths.source.data plus patterns data'
         );
       } catch (err) {
-        logger.warning('There was an error parsing JSON for patternlab.data');
-        logger.warning(err);
+        logger.error('There was an error parsing JSON for patternlab.data');
+        logger.error(err);
       }
       allFooterData.patternLabFoot = footerPartial;
 

packages/core/src/lib/compose.js

@@ -168,10 +168,10 @@ module.exports = async function (pattern, patternlab) {
               'config.paths.source.data global data'
             );
           } catch (err) {
-            logger.info(
+            logger.error(
               'There was an error parsing JSON for ' + pattern.relPath
             );
-            logger.info(err);
+            logger.error(err);
           }
           allFooterData = _.merge(allFooterData, pattern.jsonFileData);
           allFooterData.cacheBuster = patternlab.cacheBuster;

packages/core/src/lib/loadPattern.js

@@ -94,10 +94,10 @@ module.exports = function (relPath, patternlab) {
       );
     }
   } catch (err) {
-    logger.warning(
+    logger.error(
       `There was an error parsing sibling JSON for ${currentPattern.relPath}`
     );
-    logger.warning(err);
+    logger.error(err);
   }
 
   //look for a listitems.json file for this template
@@ -118,10 +118,10 @@ module.exports = function (relPath, patternlab) {
       buildListItems(currentPattern);
     }
   } catch (err) {
-    logger.warning(
+    logger.error(
       `There was an error parsing sibling listitem JSON for ${currentPattern.relPath}`
     );
-    logger.warning(err);
+    logger.error(err);
   }
 
   //look for a markdown file for this template

packages/core/src/lib/parameter_hunter.js

@@ -289,7 +289,7 @@ const parameter_hunter = function () {
               paramData = JSON.parse(paramStringWellFormed);
             } catch (err) {
               logger.warning(
-                `There was an error parsing JSON for ${pattern.relPath}`
+                `There was a problem parsing JSON parameters for ${pattern.relPath}`
               );
               logger.warning(err);
             }

packages/core/src/lib/parseLink.js

@@ -84,8 +84,8 @@ module.exports = function (patternlab, obj, key) {
   try {
     dataObj = JSON.parse(dataObjAsString);
   } catch (err) {
-    logger.warning(`There was an error parsing JSON for ${key}`);
-    logger.warning(err);
+    logger.error(`There was an error parsing JSON for ${key}`);
+    logger.error(err);
   }
 
   return dataObj;

packages/core/src/lib/pseudopattern_hunter.js

@@ -54,10 +54,10 @@ pseudopattern_hunter.prototype.find_pseudopatterns = function (
           fs.readFileSync(variantFileFullPath, 'utf8')
         );
       } catch (err) {
-        logger.warning(
+        logger.error(
           `There was an error parsing pseudopattern JSON for ${currentPattern.relPath}`
         );
-        logger.warning(err);
+        logger.error(err);
       }
 
       //extend any existing data with variant data

packages/core/src/lib/readDocumentation.js

@@ -73,10 +73,10 @@ module.exports = function (pattern, patternlab, isVariant) {
   } catch (err) {
     // do nothing when file not found
     if (err.code !== 'ENOENT') {
-      logger.warning(
+      logger.error(
         `There was an error setting pattern keys after markdown parsing of the companion file for pattern ${pattern.patternPartial}${FILE_EXTENSION}`
       );
-      logger.warning(err);
+      logger.error(err);
     }
   }
 

packages/plugin-tab/src/tab-loader.js

@@ -80,11 +80,11 @@ async function findTab(patternlab, pattern) {
         });
       }
     } catch (err) {
-      console.log(
+      console.error(
         'plugin-tab: There was an error parsing sibling JSON for ' +
           pattern.relPath
       );
-      console.log(err);
+      console.error(err);
     }
   }
 }