feat(Wizard): replace deprecations in examples #11298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrances17
requested review from
kmcfaul and
tlabaj
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-11298.surge.sh A11y report: https://patternfly-react-pr-11298-a11y.surge.sh |
thatblindgeye
requested changes
Dec 3, 2024
packages/react-core/src/components/Wizard/examples/WizardWithinModal.tsx
Outdated
Show resolved
Hide resolved
mfrances17
force-pushed
the
update-wiz-examples
branch
from
be92ebb to
099dd9d
Compare
thatblindgeye
approved these changes
Dec 4, 2024
kmcfaul
approved these changes
Dec 9, 2024
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Feb 14, 2025
* feat(Wizard): replace deprecations in examples * rm modalbody from example and revise modal doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11192
There do not appear to be any examples or demos that are currently importing the deprecated wizard, however in one of the
Wizardexamples, it was using a deprecated version ofModal, so I updated it accordingly. I also changed thatWizardWithinModalexample to a function component type because it stood out on the examples page as the only JS example (as opposed to TS), when it didn't need to be.