chore: use new JSX transform #11328
Closed
chore: use new JSX transform #11328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-11328.surge.sh A11y report: https://patternfly-react-pr-11328-a11y.surge.sh |
jonkoops
force-pushed
the
new-jsx-transform
branch
3 times, most recently
from
f5a566f to
ebcfac4
Compare
Closes patternfly#9289 Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
force-pushed
the
new-jsx-transform
branch
from
ebcfac4 to
021904b
Compare
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Contributor
Author
|
@mfrances17 looks like this one is being marked as stale. I believe you are picking up the related issue right now? Should we close this PR? |
Contributor
|
@jonkoops yeah i think we can close this PR, and i'll handle it separately |
Contributor
|
Closing this PR as it's been around for a while and is getting marked as stale. The work for using the new JSX transform will be handled in a separate upcoming PR. |
Contributor
Author
|
Great, feel free to ping me for a review if you need an extra set of eyes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the new JSX transform which removes the need to import React in every file that contains JSX. This is a change required to add support for React 19.
Also adds linting configuration to support the new transformation, including a rule to ban the default React import (
import React from 'react') in favor of named imports. The linter is set up to warn for now, as a refactor will have to come over multiple subsequent PRs.Closes #9289