Introduce fuzzing for payjoin #1153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 20795939240Details
💛 - Coveralls |
Collaborator
Author
|
Following the summit I thought it would be a good idea to try and follow the way that |
Collaborator
Author
|
I excluded fuzzing from linting as the crate does not follow |
benalleng
changed the title
benalleng
force-pushed
the
fuzzing
branch
9 times, most recently
from
33b9aeb to
cfcd3fe
Compare
This commit adds fuzzing infrastructure for payjoin with the inclusion of three engine options, cargo-fuzz (libfuzzer-sys), afl++, and honggfuzz. These two were chosen as they come with seperate tradeoffs in regards to speed and error handling. Because these two fuzzers are setup as mutually exclusive fuzzers within the same target file fuzzing cannot reasonably be built with `--all-features`. In addition honggfuzz and afl are seemingly broken on nix so I don't think it is reasonably possible at this time to nixify our fuzzing crate.
benalleng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fuzzing infrastructure for payjoin with the inclusion
of three engine options, cargo-fuzz (libfuzzer-sys), afl++, and honggfuzz. These
two were chosen as they come with seperate tradeoffs in regards to speed
and error handling.
Because these two fuzzers are setup as mutually exclusive fuzzers within
the same target file fuzzing cannot reasonably be built with
--all-features.In addition honggfuzz and afl are seemingly broken on nix so I don't think it is reasonably
possible at this time to nixify our fuzzing crate.
The readme for reading pleasure https://github.com/benalleng/rust-payjoin/blob/fuzzing/fuzz/README.md
NB The tests that I have written are not guaranteed as good fuzzing targets and that I my hope for the mob coding session on Wednesday 1/14 next week to shore up before this is merge-able
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.