Specifi nginx via environment variable or skip test #1237
+70
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 20374581801Details
💛 - Coveralls |
nothingmuch
requested changes
Dec 18, 2025
Collaborator
nothingmuch
left a comment
nothingmuch
left a comment
There was a problem hiding this comment.
This looks good, I have only one suggestion to use an error enum { NginxNotAvailable, UnknownError(Box<dyn Error>) } instead of also making the NginxNotAvailable condition into a trait object, since these two branches are handled quite differently
This pr addresses payjoin#1227, it specifies an enironment variable for nginx which will be used during test run. it also removes nginxWithStream package from the dev shell. introduce error enum for nginx failures introduce error enum for nginx failures
nothingmuch
approved these changes
Dec 19, 2025
Collaborator
nothingmuch
left a comment
nothingmuch
left a comment
There was a problem hiding this comment.
ACK.
since i opened the issue and suggested this solution i think another maintainer should at least concept ACK before merging
spacebear21
approved these changes
Dec 19, 2025
Collaborator
There was a problem hiding this comment.
partial tACK on c8017eb - I tested contrib/test.sh locally without nix and confirmed it skips the problematic tests.
We should be able to also remove the "add nginxWithStream to PATH" step in CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses #1227, it specifies an enironment variable for nginx which will be used during test run. it also removes nginxWithStream package from the dev shell.
i used Claude AI to help me with nix
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.