Skip to content

Conversation

@0xZaddyy
Copy link
Contributor

@0xZaddyy 0xZaddyy commented Jun 3, 2025

This PR updates all references to BIP-77 by replacing links to the original pull request with direct links to the now merged BIP-77 document in the BIPs master branch.
No other content changes were made.

closes #731

@zealsham
Copy link
Collaborator

zealsham commented Jun 3, 2025

ACK

Could you squash your commits for a cleaner history

@0xZaddyy
Copy link
Contributor Author

0xZaddyy commented Jun 3, 2025

Done, Thank you!

Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0xZaddyy and @zealsham for the review.

ACK, grep-ed the codebase for pull/1483 and found no other instances. I also noticed a BIP78 link referenced a fork of bitcoin/bips so I fixed that in a separate commit.

@0xZaddyy
Copy link
Contributor Author

0xZaddyy commented Jun 3, 2025

I didn't even notice the error with the bip78
Thank you!

@spacebear21 spacebear21 merged commit 5fe13e5 into payjoin:master Jun 3, 2025
13 checks passed
@coveralls
Copy link
Collaborator

coveralls commented Jun 4, 2025

Pull Request Test Coverage Report for Build 15427839047

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.833%

Totals Coverage Status
Change from base Build 15425471520: 0.0%
Covered Lines: 6617
Relevant Lines: 7800

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Bip77 Links

4 participants