Remove redis from macos CI workflow #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 15448107595Details
💛 - Coveralls |
We should use the redis within the payjoin-test-utils and not install redis seperately.
benalleng
force-pushed
the
redis-ci-workflow
branch
from
167e3f2 to
9b8eeaf
Compare
Collaborator
Author
|
Workflow with python tests passes on 167e3f2 https://github.com/payjoin/rust-payjoin/actions/runs/15447689259 9b8eeaf just removes the build forcing change 6fb7547 from the history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use the redis within the payjoin-test-utils and not install redis seperately.
I think the issue cropped up parallel to the fact that macos worker does not natively have access to docker so I was having trouble getting those both solved at the same time but as it turns out we can simply remove the redis dep directly from the CI workflow without any additional changes!