Fix Options During Validator Creation #221
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There's a small bug with the validator library where the
optionswe're creating for the validator aren't the same that get passed to the internal validators. You can see on line 88 that we create a newoptionsvariable using theopts...that were passed in from the user. We then use that newoptionsto create our validator; however, we then fallback and use the originalopts...rather than the one we created.The issue with the current approach is that it's not calling the NewValidationOptions function so we don't get any of the defaulting. We only have what the user gave us (which is likely nothing).
Really what this translates to is:
options. However,opts...likely doesn't have anything set so its cache will be either be null or empty.