Skip to content

Remove as_sf parameter #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdil merged 1 commit into from
May 30, 2025
Merged

Remove as_sf parameter #50

pdil merged 1 commit into from
May 30, 2025

Conversation

@pdil
Copy link
Owner

@pdil pdil commented May 30, 2025 •
edited
Loading

Changes

  • Removed as_sf parameter from us_map(), centroid_labels(), and fips_data()

Notes

  • as_sf was deprecated (and made defunct) in usmapdata 0.2.1 over one year ago.
  • usmap no longer makes use of this parameter and it has not had any effect since.
  • Any usmapdata function calls making use of this parameter can safely remove it.

resolves #47

@pdil pdil added this to the v1.0.0 milestone May 30, 2025
@pdil pdil added the tech Technical issues and pull requests not directly related to usmapdata functionality label May 30, 2025
@pdil pdil changed the title Remove as_sf parameter Remove as_sf parameter May 30, 2025
@pdil pdil changed the base branch from master to milestone/1.0.0 May 30, 2025 16:25
@pdil pdil merged commit 809705f into milestone/1.0.0 May 30, 2025
8 checks passed
@pdil pdil deleted the feature/remove-as_sf-parameter branch May 30, 2025 16:25
@pdil pdil mentioned this pull request May 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tech Technical issues and pull requests not directly related to usmapdata functionality

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

Remove as_sf parameter

2 participants

@pdil