Add support for building pdc sequence from xml animation file #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a frame without any draw command returns an empty list (not None)
it contains now both the command list and the duration
not to break the previous behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #8 (new branch on my fork)
It is now possible to create a pdc sequence based on definition of the animation in a xml file
The format of the xml file is inspired by the one used by apngasm
https://github.com/apngasm/apngasm/blob/master/resources/images/test.xml
which I was using previously in my project
Here is an example of such a file now for pdc
https://github.com/tardypad/pebble-watchface-amsterdam/blob/master/resources/animations/slide/chalk/animation.xml
I've put an example in the code as well as a reference
The benefits of this feature are:
I've added that feature without breaking the previous behavior of the svg2pdc tool
So for example it's still possible to use the sequence building with a folder path
There is as well a couple of tiny changes / fixes in the first commits
Let me know if you want me to split the pull request