-
Notifications
You must be signed in to change notification settings - Fork 68
K8SPG-740 fix error message #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| if repoCondition == nil || repoCondition.Status != metav1.ConditionTrue { | ||
| log.Info("pgBackRest repo host not ready, skipping backup cleanup") | ||
| return nil | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary empty line
…rator into K8SPG-740
commit: 1b1bf61 |
| return errors.Wrap(err, "reconcile backup jobs") | ||
| } | ||
|
|
||
| repoCondition := meta.FindStatusCondition(cr.Status.Conditions, postgrescluster.ConditionRepoHostReady) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this check to cleanupOutdatedBackups method
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
2025-03-04T11:01:27.724Z ERROR failed to cleanup outdated backups
Cause:
Short explanation of the root cause of the issue if applicable.
We encountered an error when attempting to delete backups while the repohost pod was not ready.
We've fixed this by checking the repohost pod status before attempting backup cleanup.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability