K8SPG-647: Fix major-upgrade test

[egegunes]

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are all needed new/changed options added to the Helm Chart?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported PG version?
• Does the change support oldest and newest supported Kubernetes version?

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shfmt

---

[shfmt] _{reported by reviewdog 🐶}

percona-postgresql-operator/e2e-tests/functions

Lines 1588 to 1594 in dc1d761

	if [[ "${huge_pages}" == *"${expected_value}"* ]]; then
	echo "PostgreSQL huge_pages is set to '${expected_value}'"
	return 0
	else
	echo "PostgreSQL huge_pages not set to '${expected_value}' (value: ${huge_pages})"
	return 1
	fi

---

[shfmt] _{reported by reviewdog 🐶}

percona-postgresql-operator/e2e-tests/functions

Lines 1598 to 1600 in dc1d761

	local pod_name=$1
	local namespace=$2
	local container=${3:-database}

---

[shfmt] _{reported by reviewdog 🐶}

percona-postgresql-operator/e2e-tests/functions

Line 1602 in dc1d761

echo "Checking hugepages usage..."

---

[shfmt] _{reported by reviewdog 🐶}

percona-postgresql-operator/e2e-tests/functions

Lines 1604 to 1605 in dc1d761

	kubectl -n ${namespace} exec ${pod_name} -c ${container} -- \
	grep HugePages /proc/meminfo

---

[shfmt] _{reported by reviewdog 🐶}

percona-postgresql-operator/e2e-tests/functions

Lines 1607 to 1608 in dc1d761

	local hugepages_total=$(kubectl -n ${namespace} exec ${pod_name} -c ${container} -- \
	grep HugePages_Total /proc/meminfo | awk '{print $2}')

---

[shfmt] _{reported by reviewdog 🐶}

percona-postgresql-operator/e2e-tests/functions

Lines 1610 to 1611 in dc1d761

	local hugepages_free=$(kubectl -n ${namespace} exec ${pod_name} -c ${container} -- \
	grep HugePages_Free /proc/meminfo | awk '{print $2}')

---

[shfmt] _{reported by reviewdog 🐶}

percona-postgresql-operator/e2e-tests/functions

Line 1613 in dc1d761

local hugepages_used=$((hugepages_total - hugepages_free))

---

[shfmt] _{reported by reviewdog 🐶}

percona-postgresql-operator/e2e-tests/functions

Lines 1615 to 1618 in dc1d761

	echo ""
	echo "HugePages usage:"
	echo " Total: ${hugepages_total}"
	echo " Used: ${hugepages_used}"

---

[shfmt] _{reported by reviewdog 🐶}

percona-postgresql-operator/e2e-tests/functions

Lines 1620 to 1627 in dc1d761

	if [ "${hugepages_used}" -gt 0 ]; then
	echo "PostgreSQL is using hugepages"
	return 0
	else
	echo "Hugepages available but NOT being used by PostgreSQL"
	return 1
	fi
	}

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	"custom-extensions"| "builtin-extensions"| major-upgrade*)
	"custom-extensions" | "builtin-extensions" | major-upgrade*)

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	local namespace=$1
	local pod=$2
	local container=$3
	local namespace=$1
	local pod=$2
	local container=$3

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	if [ -n "$container" ]; then
	kubectl exec -n "$namespace" "$pod" -c "$container" -- printenv 2>/dev/null || true
	else
	kubectl exec -n "$namespace" "$pod" -- printenv 2>/dev/null || true
	fi
	if [ -n "$container" ]; then
	kubectl exec -n "$namespace" "$pod" -c "$container" -- printenv 2>/dev/null || true
	else
	kubectl exec -n "$namespace" "$pod" -- printenv 2>/dev/null || true
	fi

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	local check_type=$1
	local pod=$2
	local var_name=$3
	local expected_value=$4
	local env_content=$5
	local actual_value
	actual_value=$(echo "$env_content" | grep -E "^${var_name}=" | cut -d'=' -f2- || true)
	if [[ "$check_type" == "add" ]]; then
	if [ "$actual_value" != "$expected_value" ]; then
	echo "ERROR: $var_name in $pod — expected '$expected_value', got '${actual_value:-<missing>}'"
	return 1
	else
	echo "OK: $var_name=$actual_value in $pod"
	fi
	elif [[ "$check_type" == "delete" ]]; then
	if [ -n "$actual_value" ]; then
	echo "ERROR: $var_name exists in $pod (should not exist)"
	return 1
	else
	echo "OK: $var_name deleted in $pod"
	fi
	else
	echo "ERROR: unknown check type '$check_type'"
	return 1
	fi
	local check_type=$1
	local pod=$2
	local var_name=$3
	local expected_value=$4
	local env_content=$5
	local actual_value
	actual_value=$(echo "$env_content" | grep -E "^${var_name}=" | cut -d'=' -f2- || true)
	if [[ $check_type == "add" ]]; then
	if [ "$actual_value" != "$expected_value" ]; then
	echo "ERROR: $var_name in $pod — expected '$expected_value', got '${actual_value:-<missing>}'"
	return 1
	else
	echo "OK: $var_name=$actual_value in $pod"
	fi
	elif [[ $check_type == "delete" ]]; then
	if [ -n "$actual_value" ]; then
	echo "ERROR: $var_name exists in $pod (should not exist)"
	return 1
	else
	echo "OK: $var_name deleted in $pod"
	fi
	else
	echo "ERROR: unknown check type '$check_type'"
	return 1
	fi

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	local check_type=$1 # add | delete
	local component=$2 # instance | pgbouncer | repohost
	local vars=("${@:3}") # everything after the 2nd argument
	case "$component" in
	instance)
	POD=$(kubectl get -n "${NAMESPACE}" pod -l postgres-operator.crunchydata.com/instance-set=instance1 -o 'jsonpath={.items[0].metadata.name}')
	CONTAINER=""
	;;
	pgbouncer)
	POD=$(kubectl get -n "${NAMESPACE}" pod -l postgres-operator.crunchydata.com/role=pgbouncer -o 'jsonpath={.items[0].metadata.name}')
	CONTAINER="pgbouncer"
	;;
	repohost)
	POD=$(kubectl get -n "${NAMESPACE}" pod -l postgres-operator.crunchydata.com/data=pgbackrest -o 'jsonpath={.items[0].metadata.name}')
	CONTAINER="pgbackrest"
	;;
	*)
	echo "ERROR: unknown component '$component'"
	return 1
	;;
	esac
	echo "Fetching environment variables for $component pod $POD..."
	local env_content
	env_content=$(get_envs_from_pod "${NAMESPACE}" "$POD" "$CONTAINER")
	local errors=0
	for var_entry in "${vars[@]}"; do
	if [[ "$check_type" == "add" ]]; then
	local var_name="${var_entry%%=*}"
	local var_expected="${var_entry#*=}"
	check_env_in_pod add "$POD" "$var_name" "$var_expected" "$env_content" || errors=$((errors+1))
	else
	check_env_in_pod delete "$POD" "$var_entry" "" "$env_content" || errors=$((errors+1))
	fi
	done
	if (( errors > 0 )); then
	echo "$errors environment check(s) failed for component '$component'"
	return 1
	else
	echo "All environment checks passed for component '$component'"
	fi
	local check_type=$1 # add | delete
	local component=$2 # instance | pgbouncer | repohost
	local vars=("${@:3}") # everything after the 2nd argument
	case "$component" in
	instance)
	POD=$(kubectl get -n "${NAMESPACE}" pod -l postgres-operator.crunchydata.com/instance-set=instance1 -o 'jsonpath={.items[0].metadata.name}')
	CONTAINER=""
	;;
	pgbouncer)
	POD=$(kubectl get -n "${NAMESPACE}" pod -l postgres-operator.crunchydata.com/role=pgbouncer -o 'jsonpath={.items[0].metadata.name}')
	CONTAINER="pgbouncer"
	;;
	repohost)
	POD=$(kubectl get -n "${NAMESPACE}" pod -l postgres-operator.crunchydata.com/data=pgbackrest -o 'jsonpath={.items[0].metadata.name}')
	CONTAINER="pgbackrest"
	;;
	*)
	echo "ERROR: unknown component '$component'"
	return 1
	;;
	esac
	echo "Fetching environment variables for $component pod $POD..."
	local env_content
	env_content=$(get_envs_from_pod "${NAMESPACE}" "$POD" "$CONTAINER")
	local errors=0
	for var_entry in "${vars[@]}"; do
	if [[ $check_type == "add" ]]; then
	local var_name="${var_entry%%=*}"
	local var_expected="${var_entry#*=}"
	check_env_in_pod add "$POD" "$var_name" "$var_expected" "$env_content" || errors=$((errors + 1))
	else
	check_env_in_pod delete "$POD" "$var_entry" "" "$env_content" || errors=$((errors + 1))
	fi
	done
	if ((errors > 0)); then
	echo "$errors environment check(s) failed for component '$component'"
	return 1
	else
	echo "All environment checks passed for component '$component'"
	fi

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	if [ "${hugepages_total}" -gt 0 ]; then
	echo "Hugepages are available in pod"
	return 0
	else
	echo "No hugepages in pod"
	return 1
	fi
	if [ "${hugepages_total}" -gt 0 ]; then
	echo "Hugepages are available in pod"
	return 0
	else
	echo "No hugepages in pod"
	return 1
	fi

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	local cluster_name=$1
	local expected_value=${2:-try}
	local cluster_name=$1
	local expected_value=${2:-try}

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	echo "Verifying PostgreSQL huge_pages setting..."
	echo "Verifying PostgreSQL huge_pages setting..."

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	local huge_pages=$(run_psql_local \
	"SHOW huge_pages;" \
	"postgres:$(get_psql_user_pass ${cluster_name}-pguser-postgres)@$(get_psql_user_host ${cluster_name}-pguser-postgres)")
	local huge_pages=$(run_psql_local \
	"SHOW huge_pages;" \
	"postgres:$(get_psql_user_pass ${cluster_name}-pguser-postgres)@$(get_psql_user_host ${cluster_name}-pguser-postgres)")

[github-actions]

[shfmt] _{reported by reviewdog 🐶}

Suggested change

	echo "huge_pages: ${huge_pages}"
	echo "huge_pages: ${huge_pages}"

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

	"sigs.k8s.io/controller-runtime/pkg/client"

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

volumesnapshotv1 "github.com/kubernetes-csi/external-snapshotter/client/v8/apis/volumesnapshot/v1"

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

	corev1 "k8s.io/api/core/v1"

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

	"github.com/stretchr/testify/assert"
	volumesnapshotv1 "github.com/kubernetes-csi/external-snapshotter/client/v8/apis/volumesnapshot/v1"
	"github.com/stretchr/testify/assert"

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

volumesnapshotv1 "github.com/kubernetes-csi/external-snapshotter/client/v8/apis/volumesnapshot/v1"

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

"github.com/percona/percona-postgresql-operator/v2/percona/version"

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

	pgv2 "github.com/percona/percona-postgresql-operator/v2/pkg/apis/pgv2.percona.com/v2"
	"github.com/percona/percona-postgresql-operator/v2/percona/version"
	pgv2 "github.com/percona/percona-postgresql-operator/v2/pkg/apis/pgv2.percona.com/v2"

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

percona-postgresql-operator/internal/controller/standalone_pgadmin/configmap.go

Lines 15 to 16 in dc1d761

	corev1 "k8s.io/api/core/v1"

[github-actions]

[goimports-reviser] _{reported by reviewdog 🐶}

percona-postgresql-operator/internal/controller/standalone_pgadmin/service.go

Lines 16 to 19 in dc1d761

	apierrors "k8s.io/apimachinery/pkg/api/errors"
	"github.com/pkg/errors"

[JNKPercona]

Test Name	Result	Time
backup-enable-disable	passed	00:07:11
builtin-extensions	passed	00:05:03
custom-envs	passed	00:18:56
custom-extensions	passed	00:14:01
custom-tls	passed	00:04:53
database-init-sql	passed	00:02:20
demand-backup	passed	00:26:05
demand-backup-offline-snapshot	failure	00:29:25
finalizers	passed	00:03:37
init-deploy	passed	00:02:37
huge-pages	passed	00:02:57
monitoring	passed	00:06:41
monitoring-pmm3	passed	00:09:04
one-pod	passed	00:05:36
operator-self-healing	passed	00:08:57
pitr	failure	00:22:38
scaling	passed	00:05:45
scheduled-backup	failure	00:37:45
self-healing	passed	00:11:19
sidecars	passed	00:03:12
standby-pgbackrest	passed	00:11:45
standby-streaming	passed	00:09:51
start-from-backup	passed	00:13:04
tablespaces	passed	00:06:33
telemetry-transfer	passed	00:03:34
upgrade-consistency	passed	00:05:37
upgrade-minor	passed	00:07:14
users	passed	00:05:09

Summary	Value
Tests Run	28/28
Job Duration	01:48:59
Total Test Time	04:51:04

commit: dc1d761
image: perconalab/percona-postgresql-operator:PR-988-dc1d76162