Fix (create mutations for uncovered classes): adjust regex to ignore classnames which are prefixed with a classname to create mutations for#22
Open
CaptainRedbeard24 wants to merge 1 commit intopestphp:4.xfrom
Conversation
…ate mutations for
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given following classes:
and a testfile:
Currently the plugin would create mutations for both classes, even though the
UserCollectionclass does not have any tests. This is due to the Regex in\Pest\Mutate\Support\MutationGenerator::doesNotContainClassToMutate/(?:class|trait)\\s+$class.*/. The $class.* will match everything that starts with the name of the target class.This PR adds a word boundary after
$classto prevent that.