fix(GraphQL): only mark types as nonNull if they are unconditional #778

Fields that are conditionally required need to be nullable as they are only required if the fields conditions are met. Marking them as nonNull types will result in schema errors if the condition is not met for a specific object.

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Schemas/GraphQLSchema.inc

@@ -127,8 +127,8 @@ class GraphQLSchema extends Schema {
             $type = Type::listOf($type);
         }
 
-        # Make this field non-nullable if it is required
-        if ($field->required and !$ignore_required) {
+        # Make this field non-nullable if it is required and unconditional
+        if ($field->required and !$field->conditions and !$ignore_required) {
             $type = Type::nonNull($type);
         }