Merged
Conversation
Member
jaredhendrickson13
commented
Feb 23, 2025
jaredhendrickson13
commented
- Fixes an issue where PortForward associated rules were created/updated incorrectly PATCH method on /api/v2/firewall/nat/port_forward seems to set the destination incorrectly on the corresponding firewall rule #659
- Fixes an issue where the client's username and IP were not correctly passed to new objects when all firewall rules were replaces
- Fixes an issue where firewall aliases of different types could not be nested
Before we were only allowing nested aliases if the type matched which isn't necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.