Merged
Conversation
…r name in HAProxyFrontendCertificate
HAProxy: Set SSL offload certificates and alternate certificates via API
This was
linked to
issues
Mar 28, 2025
Closed
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces new API endpoints and fixes several service-related bugs while updating documentation to reflect these changes. Key changes include:
- The addition of new endpoints for DHCP Relay and HAProxy services.
- Several fixes for service status issues and DHCP server configurations.
- Updates to documentation, including navigation updates in mkdocs.yml and expanded setup instructions.
Reviewed Changes
Copilot reviewed 8 out of 23 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mkdocs.yml | Added a navigation entry for the Security Policy documentation |
| docs/index.md | Updated the "Important" block to link to the SECURITY.md file |
| docs/SECURITY.md | Expanded and reformatted security policy details |
| docs/INSTALL_AND_CONFIG.md | Revised update instructions and added guidance for backup and versioning |
Files not reviewed (15)
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Core/Endpoint.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Core/Model.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Endpoints/ServicesDHCPRelayEndpoint.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Endpoints/ServicesHAProxyFrontendCertificateEndpoint.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/BINDZone.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/DHCPRelay.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/DHCPServer.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/HAProxyBackend.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/HAProxyFrontend.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/HAProxyFrontendCertificate.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/Service.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsBINDZoneTestCase.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsDHCPRelayTestCase.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsDHCPServerTestCase.inc: Language not supported
- pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsHAProxyBackendTestCase.inc: Language not supported
Comments suppressed due to low confidence (2)
docs/index.md:43
- The updated 'Important' block appears to break the sentence across lines, which might lead to unintended whitespace or formatting issues in some markdown renderers. Consider consolidating the sentence into a single paragraph.
Unless your inquiry is regarding a [security vulnerability](SECURITY.md) or other sensitive matter, please do not
docs/SECURITY.md:9
- [nitpick] Presenting the supported versions as a continuous paragraph may reduce clarity. Consider using a table or bullet list format to clearly delineate the version information.
Currently, there are two supported versions of the package: the v2 package (pfSense-pkg-RESTAPI) and the legacy v1 package (pfSense-pkg-API). The v2 package is the latest version of the package and is actively developed and fully maintained. The legacy v1 package is no longer actively developed and is only receiving compatibility fixes and critical security updates when necessary. It is highly recommended to regularly update to the latest version of the package to ensure you are receiving important bug fixes and security updates.
…i into next_minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
Fixes
Changes
advanced_backendfield a Base64Field instead of plain StringField (services/haproxy/backend - advanced_backend is in base64 format #640) This may be a breaking change for existing integrations!refresh,retry,expireandminimumfields StringField's instead of IntegerFields (BindZone fields are of incorrect type #653) This may be a breaking change for existing integrations!idfield to select the targeted service instead ofname(/api/v2/status/services shows ipsec as not running but /api/v1/services does #634, Fix OpenVPN services actions #635)