Merged
Conversation
This commit fixes an issue where a CARP virtual IP's VHID was forced to be unique across all existing CARP virtual IPs regardless of interface. This change allows the VHID to be reused by other interfaces.
…e same #749 This addresses an issue where the ForeignModelField could unnecessarily make query when the target and local field names are the same. In large rulesets this can result in a timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
vhidfield to be unique per interface instance of globally unique. Fixes POST to /api/v2/firewall/virtual_ip expects unique VHID for the entire device #754.