fix(GraphQL): only mark types as nonNull if they are unconditional #778#780
Merged
jaredhendrickson13 merged 3 commits intomasterfrom Nov 13, 2025
Merged
fix(GraphQL): only mark types as nonNull if they are unconditional #778#780jaredhendrickson13 merged 3 commits intomasterfrom
jaredhendrickson13 merged 3 commits intomasterfrom
Conversation
Fields that are conditionally required need to be nullable as they are only required if the fields conditions are met. Marking them as nonNull types will result in schema errors if the condition is not met for a specific object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes