Draft
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This comment has been minimized.
This comment has been minimized.
levkk
changed the title
This comment has been minimized.
This comment has been minimized.
levkk
force-pushed
the
levkk-rewrite-3.0
branch
from
601478e to
8566374
Compare
levkk
force-pushed
the
levkk-rewrite-3.0
branch
from
a2c9ec8 to
1949aa8
Compare
This comment has been minimized.
This comment has been minimized.
levkk
added a commit
that referenced
this pull request
Dec 8, 2025
Refactor the query parser to be completely recursive. Use the same parser for `SELECT` and `DELETE` queries. This adds support for extracting the sharding key filter from pretty much anywhere in the query, as long as it follows our supported format: ```sql key = $1 OR key IN ($1, $2, $3) OR key = ANY($1) ``` fix #653 TODOs: 1. Use new parser for `UPDATE` and `INSERT` statements. Requires integration with #637 (split rewrite engine from parser).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgdog.unique_id()pretty much anywhere in the queryunique_idgeneration is now sync, so it can be used anywherePREPARE/EXECUTEsupport into new rewrite engineINSERTsplitting into new engine (not ready)